[BUG?] protocol.version=2 sends HTTP "Expect" headers
To
git@vger.kernel.org
Cc
Jon Simons
Jonathan Tan
From
Jeff King
Date
2018-10-31 16:03:53 UTC
Since 959dfcf42f (smart-http: Really never use Expect: 100-continue,
2011-03-14), we try to avoid sending "Expect" headers, since some
proxies apparently don't handle them well. There we have to explicitly
tell curl not to use them.

The exception is large requests with GSSAPI, as explained in c80d96ca0c
(remote-curl: fix large pushes with GSSAPI, 2013-10-31).

However, Jon Simons noticed that when using protocol.version=2, we've
started sending Expect headers again. That's because rather than going
through post_rpc(), we push the stateless data through a proxy_state
struct. And in proxy_state_init(), when we set up the headers, we do not
disable curl's Expect handling.

So a few questions:

  - is this a bug or not? I.e., do we still need to care about proxies
    that can't handle Expect? The original commit was from 2011. Maybe
    things are better now. Or maybe that's blind optimism.

    Nobody has complained yet, but that's probably just because v2 isn't
    widely deployed yet.

  - if it is a bug, how can we handle it like the v0 code? There we
    enable it only for GSSAPI on large requests. But I'm not sure we can
    know here whether the request is large, since we're inherently just
    streaming through chunked data. It looks like post_rpc tries to read
    a single packet first, and considers anything over 64k to be large.

  - alternatively, should we just leave it on for v2, and provide a
    config switch to disable it if you have a crappy proxy? I don't know
    how widespread the problem is, but I can imagine that the issue is
    subtle enough that most users wouldn't even know.

I think I've convinced myself that we probably do need to do the "peek
at the first packet" thing like post_rpc() does, but I think it might be
tricky with the way the proxy_state code is structured.

Thoughts from people with more HTTP knowledge/experience?

-Peff