Re: [PATCH 1/4] rebase -i: demonstrate obscure loose object cache bug
To
Jeff King
Cc
Ævar Arnfjörð Bjarmason
Johannes Schindelin via GitGitGadget
git@vger.kernel.org
Junio C Hamano
Johannes Schindelin
From
Johannes Sixt
See Also
Prev Ref 1 Ref 2 Ref 3
Date
2019-03-14 06:40:19 UTC
Am 13.03.19 um 17:35 schrieb Jeff King:
> On Wed, Mar 13, 2019 at 05:11:44PM +0100, Ævar Arnfjörð Bjarmason wrote:
>> As a further improvement, is there a good reason for why we wouldn't
>> pass something down to the oid machinery to say "we're only interested
>> in commits". I have a WIP series somewhere to generalize that more, but
>> e.g.  here locally:
> 
> We have get_oid_commit() and get_oid_committish() already. Should rebase
> just be using those? (I think we probably want "commit()", because we do
> not expect a "pick" line to have a tag, for example.

'pick' needs all the power of revision expressions. Not all too
infrequently I do insert a pick line with a rev expression argument.
Assuming that the resolved object is a commit is too strict.

-- Hannes