[PATCH] t5580: test cloning without file://, test fetching via UNC paths
To
git@vger.kernel.org
Cc
Johannes Schindelin
Johannes Schindelin
From
Johannes Schindelin via GitGitGadget
Date
2020-02-13 21:51:44 UTC
From: Johannes Schindelin <johannes.schindelin@gmx.de>

On Windows, it is quite common to work with network drives. The format
of the paths to network drives (or "network shares", or UNC paths) is:

	\\<server>\<share>\...

We already have a couple regression tests revolving around those types
of paths, but we missed cloning and fetching from UNC paths without
leading `file://` (and with backslashes instead of forward slashes).
This lil' patch closes that gap.

It gets a bit silly to add the commands to the name of the test script,
so let's just rename it while we're testing more UNC stuff.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
    Add more regression tests around fetching/cloning from UNC paths
    
    On Windows, we want to make sure that we can fetch and clone from
    network drives. Let's add regression tests to make sure about that.

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-143%2Fdscho%2Ftest-unc-fetch-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-143/dscho/test-unc-fetch-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/143

 t/{t5580-clone-push-unc.sh => t5580-unc-paths.sh} | 12 ++++++++++++
 1 file changed, 12 insertions(+)
 rename t/{t5580-clone-push-unc.sh => t5580-unc-paths.sh} (89%)

diff --git a/t/t5580-clone-push-unc.sh b/t/t5580-unc-paths.sh
similarity index 89%
rename from t/t5580-clone-push-unc.sh
rename to t/t5580-unc-paths.sh
index 01b52c195a..cf768b3a27 100755
--- a/t/t5580-clone-push-unc.sh
+++ b/t/t5580-unc-paths.sh
@@ -40,11 +40,23 @@ test_expect_success clone '
 	git clone "file://$UNCPATH" clone
 '
 
+test_expect_success 'clone without file://' '
+	git clone "$UNCPATH" clone-without-file
+'
+
 test_expect_success 'clone with backslashed path' '
 	BACKSLASHED="$(echo "$UNCPATH" | tr / \\\\)" &&
 	git clone "$BACKSLASHED" backslashed
 '
 
+test_expect_success fetch '
+	git init to-fetch &&
+	(
+		cd to-fetch &&
+		git fetch "$UNCPATH" master
+	)
+'
+
 test_expect_success push '
 	(
 		cd clone &&

base-commit: d8437c57fa0752716dde2d3747e7c22bf7ce2e41
-- 
gitgitgadget