Re: [PATCH v2 3/5] gitweb/Makefile: conditionally include ../GIT-VERSION-FILE
To
Ramsay Jones
Cc
Junio C Hamano
GIT Mailing-list
From
Felipe Contreras
See Also
Prev
Date
2020-12-07 03:26:09 UTC
On Sun, Dec 6, 2020 at 6:37 PM Ramsay Jones <ramsay@ramsayjones.plus.com> wrote:

> Notice that the 'clean' target is making a nested call to the parent
> Makefile to ensure that the GIT-VERSION-FILE is up-to-date. This is to
> ensure that the $(GIT_VERSION) make variable is set, once that file had
> been included. However, the 'clean' target does not use the $(GIT_VERSION)
> variable, so this is wasted effort.

Same goes here.

-- 
Felipe Contreras